brew unbottled: skip deprecated

[iMichka]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[apainintheneck]

Suggested change

	formulae = formulae&.select {|formula| !(formula.deprecated?)}
	all_formulae = all_formulae&.select {|formula| !(formula.deprecated?)}
	formula_installs = formula_installs&.select {|formula| !(formula.deprecated?)}
	formulae.reject!(&:deprecated?)
	all_formulae.reject!(&:deprecated?)

It looks like formula_installs is just a hash of names to installs that gets referenced based on the formulae in the other lists so removing information there is probably unnecessary.

[iMichka]

Makes sense, fixed

[apainintheneck]

Nit: Using Array#reject!(&:deprecated?) here is both more idiomatic Ruby and less code in general.

[apainintheneck]

Would it make sense to make this the default?

[MikeMcQuaid]

Would it make sense to make this the default?

Yes, I think so. I can't think of a situation where you'd actively be trying to bottle deprecated formulae so even the inverse option (--include-deprecated) wouldn't make sense to me either.

[iMichka]

Makes sense. I changed the logic and I am now always skipping deprecated formulae. Let's gather more insights because there might be edge cases we did not think of.

[MikeMcQuaid]

Thanks again @iMichka and @apainintheneck for review!