Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: fix specified_path for aliases without core tap #16280

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 1, 2023

This previously assumed a non-nil alias_path would always exist where the unresolved path exists. This is not always true with untapped core taps - e.g. if we download the Ruby source or use it from a bottle (post-install) then the we have the original file but not the aliased symlink.

Fixes some errors installing by alias, e.g.

Error: An exception occurred within a child process:
  FormulaUnavailableError: No available formula with the name "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Aliases/crypto++".

Technically speaking this means methods like alias_name etc will not be set in postinstall etc, but I don't think any formula uses that information and would be a bigger refactor to fix.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit ee5f337 into Homebrew:master Dec 1, 2023
24 checks passed
@Bo98 Bo98 deleted the specified_path-alias-fix branch December 1, 2023 17:23
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants