formula: fix specified_path for aliases without core tap #16280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously assumed a non-nil alias_path would always exist where the unresolved path exists. This is not always true with untapped core taps - e.g. if we download the Ruby source or use it from a bottle (post-install) then the we have the original file but not the aliased symlink.
Fixes some errors installing by alias, e.g.
Technically speaking this means methods like
alias_name
etc will not be set in postinstall etc, but I don't think any formula uses that information and would be a bigger refactor to fix.