Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pin: Update pinned formula messaging #16301

Merged

Commits on Dec 8, 2023

  1. cmd/pin: Update pinned formula messaging

    The hope is that this will be clearer and less annoying for users.
    
    A user came to us a couple weeks ago stating that it was confusing
    that the `brew upgrade` command printed an error when a pinned
    formula had a new version available and didn't get upgraded.
    
    This PR changes that message to a warning from an error. While looking
    into this we found that there is another message that gets printed
    when a package dependency doesn't get upgraded because it is pinned
    and that got turned into a warning from a normal message. Honestly,
    that should be more worrying for the user anyway; it could lead to
    a program not working correctly in the worst case.
    
    I also added a message to the `brew pin` command warning about
    potential unintended behavior if a dependency gets pinned and another
    package requires a newer version of it.
    
    Lastly, I added a commented out deprecation notice for the
    `brew upgrade --ignore-pinned` command since it's now the default.
    apainintheneck committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b3a6e59 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. cmd/upgrade: Error when attempting to explicitly upgrade a pinned pkg

    The idea here is that it should be expected that `brew upgrade` will
    not upgrade pinned packages but will attempt to upgrade everything else.
    For that reason, it will only show a warning about pinned packages
    in that case.
    
    If, on the other hand, you pass the name of a pinned package explicitly
    to the upgrade command, like in `brew upgrade PINNED`, we want to show
    an error since we cannot upgrade that package until it gets unpinned.
    apainintheneck committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9a00f27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0da6bd View commit details
    Browse the repository at this point in the history