Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant Rails cops #16403

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Dec 26, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

relates to #16190 and #16190 (comment) in particular

This removes Rails cops that can't trigger (or be resolved, in the case of Rails/Delegate), bc we aren't requiring the components of ActiveSupport that they pertain to. This reduces our surface ActiveSupport dependency surface area a tiny bit, and saves us a few flops on builds.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks again @dduugg !

@MikeMcQuaid MikeMcQuaid merged commit 500a6b1 into Homebrew:master Dec 27, 2023
24 checks passed
@dduugg dduugg deleted the trim-rubocop-rails branch December 27, 2023 17:53
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants