Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ActiveSupport from runtime #16463
Remove ActiveSupport from runtime #16463
Changes from all commits
08e12b2
5546f77
f8de5df
b60d951
2e21eff
7ae087b
c02520f
79e2379
8e9d294
0cdd4ee
a87cdf0
14f8a08
f6c7eb7
8efe73b
fa7b8ff
1790904
4c25250
44e6b48
66aff2a
53bba9c
df140b3
2f8ad2f
1a40468
e574904
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scoped these to the files that used them, rather than in
global
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes that are required when adding
sig
s to vendored methodsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen this pattern in the wild. Very cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elem
is an upstream RBI creation that isn't available at runtime, so these need to be in RBI files. (And similarly forEnumerable::Enum
,Hash::K
,Hash::V
, etc. below…)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use a runtime
sig
withreturns(T.self_type)
, but that's a bug: sorbet/sorbet#7586There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visibility modifier added due to code comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubocop formatting change
Check warning on line 77 in Library/Homebrew/extend/file/atomic.rb
Codecov / codecov/patch
Library/Homebrew/extend/file/atomic.rb#L77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubocop-performance wanted these changes ¯\(ツ)/¯
Check warning on line 25 in Library/Homebrew/extend/hash/deep_transform_values.rb
Codecov / codecov/patch
Library/Homebrew/extend/hash/deep_transform_values.rb#L25