Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/upgrade: rename arg to installed_formula/cask #16528

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jan 24, 2024

This avoids running brew outdated in shell completions, which is noticeably slow.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @cho-m!

This avoids running `brew outdated` in shell completions, which is
noticeably slow.
@cho-m cho-m force-pushed the brew-upgrade-faster-completion branch from dc5afc7 to 6bc6aae Compare January 24, 2024 17:46
@cho-m cho-m changed the title cmd/upgrade: rename arg to installed_formulae/casks cmd/upgrade: rename arg to installed_formula/cask Jan 24, 2024
@MikeMcQuaid MikeMcQuaid merged commit a42a7ea into Homebrew:master Jan 24, 2024
25 checks passed
@cho-m cho-m deleted the brew-upgrade-faster-completion branch January 24, 2024 18:10
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants