Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: fix codecov reporting after v4 #16584

Merged
merged 1 commit into from
Feb 23, 2024
Merged

workflows/tests: fix codecov reporting after v4 #16584

merged 1 commit into from
Feb 23, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 4, 2024

Was a documented breaking change

The lack of token in PRs is still OK as it does still support tokenless uploading for only those scenarios.

@Bo98 Bo98 marked this pull request as draft February 5, 2024 00:02
@Bo98
Copy link
Member Author

Bo98 commented Feb 5, 2024

Needs a fix for codecov/codecov-action#1258 and codecov/feedback#263.

@Bo98
Copy link
Member Author

Bo98 commented Feb 6, 2024

Might work when codecov/codecov-action@f62c5ee ships in a new tag (though I suppose we could point to that commit manually, idk how Dependabot handles that situation)

@MikeMcQuaid
Copy link
Member

Might work when codecov/codecov-action@f62c5ee ships in a new tag (though I suppose we could point to that commit manually, idk how Dependabot handles that situation)

Cool, thanks 👍🏻. I'm happy to just wait if you are.

@Bo98 Bo98 marked this pull request as ready for review February 23, 2024 19:34
@Bo98 Bo98 merged commit 1d614fc into master Feb 23, 2024
27 checks passed
@Bo98 Bo98 deleted the codecov-fix branch February 23, 2024 19:34
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants