Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Formulary::loader_for. #16623

Merged
merged 19 commits into from
Feb 15, 2024
Merged

Refactor Formulary::loader_for. #16623

merged 19 commits into from
Feb 15, 2024

Commits on Feb 14, 2024

  1. Refactor Formulary::loader_for.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    4 Configuration menu
    Copy the full SHA
    4641690 View commit details
    Browse the repository at this point in the history

  2. Fix code style.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d70f719 View commit details
    Browse the repository at this point in the history

  3. Revert diagnostic change.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ecee4ae View commit details
    Browse the repository at this point in the history

  4. Remove Formulary::tap_paths again.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0f4d912 View commit details
    Browse the repository at this point in the history

  5. Remove redundant debug output.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0626f62 View commit details
    Browse the repository at this point in the history

  6. Fix loading versioned casks/formulae from API.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    61a283e View commit details
    Browse the repository at this point in the history

  7. Avoid T.cast.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ba29328 View commit details
    Browse the repository at this point in the history

  8. Simplify conditional.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    22bb157 View commit details
    Browse the repository at this point in the history

  9. Simplify test.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c5a877d View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary if.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    562d529 View commit details
    Browse the repository at this point in the history

  11. Always prefer the default tap.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    eb48d6b View commit details
    Browse the repository at this point in the history

  12. Fix tap constants.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    726aeca View commit details
    Browse the repository at this point in the history

  13. Add separate loader for default tap.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9056613 View commit details
    Browse the repository at this point in the history

  14. Handle TapFormulaAmbiguityError in diagnostics.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ce60048 View commit details
    Browse the repository at this point in the history

  15. Fix type signature.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    f4ac299 View commit details
    Browse the repository at this point in the history

  16. Fix code style.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    177e916 View commit details
    Browse the repository at this point in the history

  17. Remove unused TapFormulaWithOldnameAmbiguityError.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b717f5d View commit details
    Browse the repository at this point in the history

  18. Fix FromDefaultNameLoader.

    @reitermarkus
    reitermarkus committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fe1f6c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Use FromDefaultNameLoader for diagnostics.

    @reitermarkus
    reitermarkus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    efa6130 View commit details
    Browse the repository at this point in the history