dev-cmd/bump*: do not allow forcing multiple PRs. #16664
Conversation
After/if Homebrew/brew#16664 is merged, this is needed for `autobump` to open PRs that may be detected as duplicates.
If there are duplicate PRs: we shouldn't suggest and allow a trivial override. Instead, they should be created manually. An undocumented override exists for BrewTestBot to do autobumps.
MikeMcQuaid
force-pushed
the
bump_no_force
branch
from
b3a3eb9
to
7df07b9
Compare
What about regular false positives though? Every now end then I sometimes used it because the command detected PRs with just the formula name in it as a duplicate when those PRs were unrelated because either about others formulas referencing that one, either some PR to modify it but that wasn't a version bump and not close to be merged (eg. adding a build option, adding documentation and so on) and while this other PR was either discussed or stalled with no one taking care of it for now, there's no reason to delay the version bump, right? (Note, the detection could also match both the formula name and the version, which doesn't seems to be the case currently?) |
Short-term: create the PR manually.
This seems like a good idea 👍🏻 |
#828) … PR bump Issue #, if available: *Description of changes:* The latest release of Homebrew does not allow forcing multiple PRs (Homebrew/brew#16664). This causes the `release-homebrew` workflow to fail as it uses the `--force` option in `bump-cask-pr` command which is disabled as of brew version 4.2.9. This PR removes the `--force` flag to fix the workflow step. Recent Homebrew workflow failure: https://github.com/runfinch/finch/actions/runs/7997204281/job/21841199683 *Testing done:* - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Mrudul Harwani <[email protected]>
If there are duplicate PRs: we shouldn't suggest and allow a trivial override. Instead, they should be created manually.
An undocumented override exists for BrewTestBot to do autobumps.