Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Refactor Formulary::loader_for." #16689

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 16, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Re-reverts #16684 and fixes Homebrew/homebrew-core#162946.

Also depends on the fix in #16688.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Hold off merging until you can be offline for 2-4 hours to fix any reported regressions please @reitermarkus.

@reitermarkus reitermarkus merged commit d3ef383 into Homebrew:master Feb 22, 2024
31 checks passed
@reitermarkus reitermarkus deleted the formulary-loader-for branch February 22, 2024 17:41
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install git-delta using --HEAD: No available formula with the name "<hash>--git-delta".
2 participants