Generalise internal cross-image handling #16725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
force-pushed
the
cross-more-macos
branch
from
25bc8bc
to
58874de
Compare
p-linnane
approved these changes
Feb 22, 2024
MikeMcQuaid
approved these changes
Feb 23, 2024
I think it'd be worth trying to be more consistent here and use this as an opportunity to drop some older macOS versions support entirely. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to add a macOS 11 arm64 cross-build to the mix so need to make the existing cross-build logic apply to multiple macOS versions. x86_64 will probably stay on 10.11 but this is TBC depending on subsequent testing and I may try various combinations here.
Once this change is in place, I plan to build new cross-build images for Portable Ruby which I'll then test against Portable Ruby CI.