Simplify Tap#remote_repo.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Extracted from #16730 for easier review.

[apainintheneck]

I'm not sure this is really simpler. It's a few less lines I guess.

[MikeMcQuaid]

Agreed with @apainintheneck, this is worse as it actually introduces more branching logic despite being fewer lines. Passing on this, sorry.

[reitermarkus]

It's needed to work with the signature of Tap#remote, which is added in a later commit in the original PR.

[reitermarkus]

Feel free to suggest an alternative that only calls remote once.

[MikeMcQuaid]

Feel free to suggest an alternative that only calls remote once.

remote_repo = remote and then use that variable instead.

[apainintheneck]

It's needed to work with the signature of Tap#remote, which is added in a later commit in the original PR.

In that case, I'm okay with whatever appeases the type system. That goes for other PR too.

[apainintheneck]

@reitermarkus Maybe this shouldn't be a separate PR in that case though. It'd be easier to understand in context. That being said I appreciate you breaking up these in general PRs so they're easier to review.

[reitermarkus]

If I change #remote, this cascades into a bunch of other changes that are needed, like this change here, so I extracted these first.

[MikeMcQuaid]

Thanks @reitermarkus!