Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: update Python resources for non-PyPI formulae #16780

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 1, 2024

This extends previous logic to include non-PyPI formulae that are specified within pypi_formula_mappings.json.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Draft as I need to test behavior some more (particularly for any existing homebrew-core formulae that this will impact) and don't want to conflict with some of my other PRs.

Continuing some work from my other PRs to enable more formulae to automatically update Python resources.

For some non-PyPI formulae, this may require adding a line in JSON like "awscli": {}, to enable this behavior.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 23, 2024
@cho-m cho-m removed the stale No recent activity label Mar 25, 2024
@cho-m cho-m self-assigned this Mar 25, 2024
@cho-m cho-m force-pushed the bump-formula-pr-pypi-resources branch from 05641e2 to 9ebd51a Compare April 14, 2024 02:56
This extends previous logic to include non-PyPI formulae that are
specified within pypi_formula_mappings.json.

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m force-pushed the bump-formula-pr-pypi-resources branch from 9ebd51a to ff31799 Compare April 14, 2024 14:32
@cho-m
Copy link
Member Author

cho-m commented Apr 27, 2024

Going to temporarily close and re-open in a couple weeks when I have time to finish up PR.

@cho-m cho-m closed this Apr 27, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants