language/python: order args for virtualenv_install_with_resources

[cho-m]

Add without, start_with, and end_with to allow basic control over the order that resources are installed so that the situations where we have to split up virtualenv_install_with_resources is reduced.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

In homebrew-core, we've often have to running separate venv commands whenever there is an ordering problem or there are some extra resources that we don't want in venv.

In this PR, I am looking into expanding DSL to handle some of these cases.

Examples usage can include:

• jupyterlab:

  @@ -519,13 +519,11 @@ class Jupyterlab < Formula
     end
  
     def install
  -    venv = virtualenv_create(libexec, python3)
       ENV["JUPYTER_PATH"] = etc/"jupyter"
  
       # install packages into virtualenv and link all jupyter extensions
       skipped = %w[hatch-jupyter-builder hatch-nodejs-version jupyterlab-pygments notebook]
  -    venv.pip_install resources.reject { |r| skipped.include? r.name }
  -    venv.pip_install_and_link buildpath
  +    venv = virtualenv_install_with_resources without: skipped
       bin.install_symlink (libexec/"bin").glob("jupyter*")

• awscli

  @@ -133,10 +133,7 @@ class Awscli < Formula
       end
  
       # The `awscrt` resource requires `setuptools` & `wheel`, so they must be installed first
  -    venv = virtualenv_create(libexec, "python3.11", system_site_packages: false)
  -    venv.pip_install resources.reject { |r| r.name == "awscrt" }
  -    venv.pip_install resource("awscrt")
  -    venv.pip_install_and_link buildpath
  +    virtualenv_install_with_resources system_site_packages: false, end_with: "awscrt"

---

I added an exception in case that resource name doesn't exist, but can remove if we want to just ignore these.

---

EDIT: Probably need to view test diff without whitespace as I ended up indenting existing Language::Python::Virtualenv::Virtualenv (https://github.com/Homebrew/brew/pull/16817/files?diff=unified&w=1)

[MikeMcQuaid]

Great idea! Some more comments, none of which are blocking.

[apainintheneck]

In general, I like the the DSL. I left a few nits though.

The error message will be weird if someone decides to add the same name to multiple of these lists but then again, who would do that?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[cho-m]

I'll merge suggestions and then adjust remaining parts after testing out logic.

[cho-m]

Need another review as I refactored logic into separate method so want to make sure if this is good. I was trying out other loop logic from my review comment, but Sorbet doesn't seem capable of keeping track of types in that situation. I do think current logic is more readable than my other attempts.

[apainintheneck]

I agree this is easier to understand than before. The error message is a bit less specific but it should be clear enough.

[MikeMcQuaid]

Makes sense to me, thanks again @cho-m!