-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make documentation @api private
by default.
#16831
Make documentation @api private
by default.
#16831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this idea!
- https://github.com/Homebrew/homebrew-bundle/tree/master/spec/stub is pretty comprehensive for homebrew-bundle as it has 100% line coverage
- https://github.com/Homebrew/homebrew-test-bot/tree/master/spec/stub is less so but should provide a decent starting point and you can probably click around for the rest
- https://github.com/Homebrew/homebrew-services/tree/master/spec/stub is much less so but, again, can probably just click around the tap
@api public: Usable in formulae/casks, or by third-party taps.
@api internal: Usable by official taps.
@api private: Usable in Homebrew/brew.
@Private: Only used for things that can't be made private.
Would be great to explicitly document this somewhere.
I realise this is probably actively impossible but: would be great to figure out if this is enforceable at all through checks, too.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@reitermarkus Would love you to rebase this and we can get it merged when you get a bit! |
bb81ca8
to
d48e300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge when you are 👍🏻
@@ -4,8 +4,6 @@ | |||
require "dependable" | |||
|
|||
# A dependency on another Homebrew formula. | |||
# | |||
# @api private | |||
class Dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is used in Homebrew/test-bot, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couln't find it in test-bot
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b6a1964
to
1839f86
Compare
1839f86
to
0f0055e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm sure we'll need to adjust some of this over time but let's get it merged ASAP to avoid conflicts. Great work @reitermarkus!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Our API is mostly private, so make anything that is unmarked
@api private
by default.I added a
brew rubydoc --open
command to view docs locally.@Homebrew/maintainers, please check if you find anything that is currently unmarked but used outside of this repo, and add the following accordingly:
@api public
: Usable in formulae/casks, or by third-party taps.@api internal
: Usable by official taps.@api private
: Usable inHomebrew/brew
.@private
: Only used for things that can't be madeprivate
.