-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diagnostic: use FromTapLoader to check 3rd-party formula #16879
Conversation
b2d6293
to
7c143ab
Compare
7c143ab
to
f30d468
Compare
Signed-off-by: Michael Cho <[email protected]>
f30d468
to
15dd331
Compare
Do we know if this is a regression and if so, how was it implemented before? |
Yes, it's a(another) regression from all the tap/formula/cask loader related refactoring work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this when you are @cho-m, please self-merge when you're ready and thanks for the quick turnaround on a fix here.
Co-authored-by: Mike McQuaid <[email protected]>
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Might help with #16878 when name collision between existing core formula and 3rd party tap.
Seems to work locally for specific example.