Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: use FromTapLoader to check 3rd-party formula #16879

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 11, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Might help with #16878 when name collision between existing core formula and 3rd party tap.

Seems to work locally for specific example.

brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  packer
brew doctor
Your system is ready to brew.

Library/Homebrew/diagnostic.rb Outdated Show resolved Hide resolved
@apainintheneck
Copy link
Contributor

Do we know if this is a regression and if so, how was it implemented before?

@MikeMcQuaid
Copy link
Member

Do we know if this is a regression

Yes, it's a(another) regression from all the tap/formula/cask loader related refactoring work.

@MikeMcQuaid MikeMcQuaid dismissed reitermarkus’s stale review March 12, 2024 08:29

Personal preferences

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this when you are @cho-m, please self-merge when you're ready and thanks for the quick turnaround on a fix here.

Library/Homebrew/diagnostic.rb Outdated Show resolved Hide resolved
Library/Homebrew/diagnostic.rb Outdated Show resolved Hide resolved
@cho-m cho-m changed the title diagnostic: FromTapLoader fallback when checking 3rd-party formula diagnostic: use FromTapLoader to check 3rd-party formula Mar 12, 2024
@cho-m cho-m merged commit 697d416 into Homebrew:master Mar 14, 2024
31 checks passed
@cho-m cho-m deleted the diagnostic-taploader branch March 14, 2024 06:16
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants