Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and refactor rspec-its use #16907

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Remove and refactor rspec-its use #16907

merged 2 commits into from
Mar 18, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Mar 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

its was removed from RSpec 3, but available as a separate gem for backcompat. One rationale was that it was more meta than it was in line with RSpec's documentation approach.
That gem has seen one (minor) change in the past nine years.
We only use it in a handful (11) of files, and not in a way that seems especially compact or otherwise worth the trouble (IMO).
Let's just push fully forward into RSpec 3 instead.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks again @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 24dede9 into master Mar 18, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rm-rspec-its branch March 18, 2024 12:51
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants