Avoid writable_real?
#16955
Merged
Avoid writable_real?
#16955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Makes sense to me, thanks again @Bo98!
May be worth a rubocop to make sure these don't creep back in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the real UID for writability is rarely correct, unless you are doing so for security purposes in a root setuid executable (a scenario Homebrew already forbids). All file operations actually operate using the EUID.
Reverts Homebrew/legacy-homebrew#13689 - insufficient information was given in that PR to determine the actual root cause.