Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin porting non-dev commands to use AbstractCommand #16975

Merged
merged 23 commits into from
Mar 31, 2024
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Mar 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The latest release moved all the dev commands to using AbstractCommand. Since we (er, I) haven't seen any reported issues, let's start porting the non-dev commands.

(There's a bonus commit here, where i realized that require "cli/parser" should be in AbstractCommand, not its subclasses, which no longer reference the parser directly.)

Relates to #16814
See also #16938 &c.

Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on porting all of these commands over!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 21dd3c2 into master Mar 31, 2024
34 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ported-cmds branch March 31, 2024 18:28
@github-actions github-actions bot added the outdated PR was locked due to age label May 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants