Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update examples of good commit summaries #17062

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

toobuntu
Copy link
Contributor

Aligns examples with preferences observed by current maintainers.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Aligns examples with preferences observed by current maintainers.

brew typecheck on arm64 led me to this bug sorbet/sorbet#6778.

Aligns examples with preferences observed by current maintainers.
@carlocab carlocab merged commit 7c759d3 into Homebrew:master Apr 10, 2024
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @toobuntu!

@toobuntu toobuntu deleted the new-cask-message branch April 10, 2024 08:23
@github-actions github-actions bot added the outdated PR was locked due to age label May 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants