Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure_executable!: add opt_bin path to search #17106

Merged

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Apr 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This fixes the observed behavior in #17019 (comment) when running brew upgrade with attestation verification enabled.

Edit: confirmed locally that HOMEBREW_VERIFY_ATTESTATIONS=1 brew upgrade succeeds as expected with this change.

@woodruffw woodruffw requested a review from carlocab April 18, 2024 18:14
@woodruffw woodruffw self-assigned this Apr 18, 2024
@woodruffw woodruffw added the bug Reproducible Homebrew/brew bug label Apr 18, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @woodruffw!

@MikeMcQuaid MikeMcQuaid merged commit 47c2c6d into Homebrew:master Apr 19, 2024
25 checks passed
@woodruffw woodruffw deleted the ww/upgrade-fix-attestation branch April 19, 2024 13:47
@github-actions github-actions bot added the outdated PR was locked due to age label May 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants