Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_strategy: add ssh://git scheme for git download strategy #17121

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

daeho-ro
Copy link
Member

@daeho-ro daeho-ro commented Apr 21, 2024

Fixes #17120.

This can be extends the git download strategy for the url with ssh://git where this type of url is used Bitbucket server or gitlab and so on. The result command of git download strategy is

git ls-remote <url>

and actually git accepts a lot of scheme or url formats and so here I want to extends the feature.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @daeho-ro!

@MikeMcQuaid MikeMcQuaid merged commit eead9dd into Homebrew:master Apr 21, 2024
25 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label May 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new url scheme for the GitDownloadStrategy
2 participants