Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/tests: skip tests that require core if it's not tapped #17212

Merged
merged 1 commit into from
May 3, 2024
Merged

dev-cmd/tests: skip tests that require core if it's not tapped #17212

merged 1 commit into from
May 3, 2024

Commits on May 3, 2024

  1. dev-cmd/tests: skip tests that require core if it's not tapped 

    There were a few tests which require core to be tapped and fail
if it isn't. This is annoying if someone is trying to contribute
to the project and they're using the JSON API instead of having
the core repo tapped locally.

I'm just skipping these because it's the simplest thing to do.
The tests that failed are mostly rubocop tests so it's fine
if they only run on CI.
    @apainintheneck
    apainintheneck committed May 3, 2024
    Configuration menu
    Copy the full SHA
    56ecd42 View commit details
    Browse the repository at this point in the history