linkage_checker: test indirect dependencies. #17286
Conversation
Library/Homebrew/linkage_checker.rb
Outdated
| @@ -78,8 +79,8 @@ def broken_library_linkage?(test: false, strict: false) | |||
|
|
|||
| issues = [@broken_deps, @broken_dylibs] | |||
| if test | |||
| issues += [@unwanted_system_dylibs, @version_conflict_deps] | |||
| issues += [@undeclared_deps, @files_missing_rpaths, @executable_path_dylibs] if strict | |||
| issues += [@unwanted_system_dylibs, @version_conflict_deps, @indirect_deps, @undeclared_deps] | |||
There was a problem hiding this comment.
We should probably keep @undeclared_deps and @indirect_deps under strict for now, because their failures will make brew attempt a local source build after attempting a bottle install that fails these linkage tests
There was a problem hiding this comment.
@carlocab Ah, good point. Do you think the approach in Homebrew/homebrew-test-bot#1059 of requiring strict instead makes more sense? Maybe should be gated to just official taps?
There was a problem hiding this comment.
@carlocab updated this to add/keep them behind strict.
There was a problem hiding this comment.
Not seeing the update. Did you forget to push? My connection is poor at the moment tho, so I may still be seeing an old version.
There was a problem hiding this comment.
@carlocab Had bad airport internet, pushed now!
MikeMcQuaid
changed the title
Check for indirect dependencies with linkage with linkage in strict test mode. This should be done to ensure we accurately declare dependencies in homebrew/core.
MikeMcQuaid
force-pushed
the
stricter_linkage_test
branch
from
299a3d5
to
1c65495
Compare
Check for indirect dependencies with linkage with linkage in strict test mode.
This should be done to ensure we accurately declare dependencies in homebrew/core.
Alternate/complementary approach in Homebrew/homebrew-test-bot#1059