Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update for Homebrew/cask-fonts deprecation #17314

Merged
merged 1 commit into from
May 16, 2024
Merged

docs: update for Homebrew/cask-fonts deprecation #17314

merged 1 commit into from
May 16, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Updating docs to reflect the deprecation of Homebrew/cask-fonts.

@p-linnane p-linnane added the documentation Documentation changes label May 16, 2024
MikeMcQuaid
MikeMcQuaid approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @p-linnane!

MikeMcQuaid
MikeMcQuaid approved these changes May 16, 2024
View reviewed changes
Library/Homebrew/cask/audit.rb Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 7d931dd into master May 16, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the hcf-doc-updates branch May 16, 2024 16:31
saifazmi added a commit to saifazmi/dotfiles that referenced this pull request May 22, 2024
@saifazmi
[tmux + zsh] fix: issue with \uE0BA glyph overlapping
28d61f1 
- not sure what caused this, but seems like \uE0BA needs extra space
- might have been caused by the recent fonts formula update across brew
- Homebrew/brew#17314
saifazmi added a commit to saifazmi/dotfiles that referenced this pull request May 22, 2024
@saifazmi
[tmux + zsh] fix: issue with \uE0BA glyph overlapping
80f85eb 
- not sure what caused this, but seems like \uE0BA needs extra space
- might have been caused by the recent fonts formula update across brew
- Homebrew/brew#17314
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricFromCanada EricFromCanada EricFromCanada approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
documentation Documentation changes outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-linnane @MikeMcQuaid @EricFromCanada