-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew tab
: new command for editing tab information
#17449
Conversation
Library/Homebrew/test/support/helper/spec/shared_context/integration_test.rb
Outdated
Show resolved
Hide resolved
75a5230
to
ea0809b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Looks good from a brief look but hold off merging until after next stable release so I can do a proper review tomorrow. Thanks again ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks @ZhongRuoyu!
I'm not sure this is ready after seeing other comments.
Just to note: Feels a lot to type though - might be worth shortening to |
For consistency I chose to go with the flags already present in $ brew leaves --help
Usage: brew leaves [--installed-on-request] [--installed-as-dependency]
List installed formulae that are not dependencies of another installed formula
or cask.
-r, --installed-on-request Only list leaves that were manually
installed.
-p, --installed-as-dependency Only list leaves that were installed as
dependencies. But perhaps we can add short flags. Need to come up with a short flag for the negation (e.g., |
I feel given it's less "safe" (i.e. can trigger autoremove): we probably don't need a short flag for this. |
Add `brew tab`, a new command to edit tab information, as previously discussed in #17125 (comment). Currently, this supports marking or unmarking formulae as installed on request. Sample usage: $ brew tab --installed-on-request curl ==> curl is now marked as installed on request. $ brew autoremove --dry-run [no output] $ brew tab --no-installed-on-request curl ==> curl is now marked as not installed on request. $ brew autoremove --dry-run ==> Would autoremove 2 unneeded formulae: curl rtmpdump Co-authored-by: Mike McQuaid <[email protected]>
brew tab
: new command for editing tab information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again @ZhongRuoyu!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Add
brew tab
, a new command to edit tab information, as previously discussed in #17125 (comment). Currently, this supports marking or unmarking formulae as installed on request.Sample usage: