Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API for description searches #17582

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Use API for description searches #17582

merged 3 commits into from
Jul 1, 2024

Commits on Jul 1, 2024

  1. Use API for description searches 

    Both `brew search --desc` and `brew desc --search` use API for cask and
formula searches unless `--eval-all` or `HOMEBREW_EVAL_ALL` set.
Description searches do not use the description cache or eval any
formulas/casks.

- With `--eval-all`, description search reverts to the old behavior.
- Warn if description search exludes any formulae/casks (because
  `--eval-all` not set).
- Enforce `--eval-all` requirement if NO_INSTALL_FROM_API set.
    @rrotter
    rrotter committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    99486c8 View commit details
    Browse the repository at this point in the history

  2. test brew desc -s works w/ API w/o --eval-all

    @rrotter
    rrotter committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4f6771c View commit details
    Browse the repository at this point in the history

  3. test Search.search_descriptions

    @rrotter
    rrotter committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    816fe36 View commit details
    Browse the repository at this point in the history