Remove redundant early return in livecheck skip_conditions
#17591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is currently blocking #17586, #17586, and #17587:
As far as I can tell,
brew typecheck
is correct thatcheck
can never be falsey at this point. I believe that onlyFormula
,Cask::Cask
, andResource
implement#livecheckable?
, so I don't think there's a way forpackage_or_resource
to not match one of the three cases.If we are worried, we can also change the next line to be
checks&.each do |method_name|
.