Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume the --greedy flag for brew outdated when HOMEBREW_UPGRADE_GREEDY is set #17668

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

andrewbraxton
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If a user has set the HOMEBREW_UPGRADE_GREEDY env var, it implies that they are interested in always having their Casks upgraded "greedily" during brew upgrade.

It follows that such a user would additionally always be interested in knowing whether their Casks are "greedily" outdated when running brew outdated. Thus, this change makes brew outdated respect HOMEBREW_UPGRADE_GREEDY in the same manner as brew upgrade.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Think the diff can be minimised.

Library/Homebrew/cmd/outdated.rb Outdated Show resolved Hide resolved
@andrewbraxton andrewbraxton marked this pull request as ready for review July 11, 2024 06:09
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @andrewbraxton!

@MikeMcQuaid MikeMcQuaid merged commit 4bd3b93 into Homebrew:master Jul 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants