Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/dev-cmd/bottle: Mark the bottling test as needs_network #17680

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 12, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • I was on a plane and this failed with:
expected block to not output to stderr, but output
"curl: (6) Could not resolve host: spdx.github.io\nWarning: Failed to fetch SBOM schema, cannot perform SBOM validation!
Warning: Could not fetch JSON schema to validate SBOM!\nWarning: SBOM is not valid, not writing to disk!"

- I was on a plane and this failed with:

```
expected block to not output to stderr, but output
"curl: (6) Could not resolve host: spdx.github.io\nWarning: Failed to fetch SBOM schema, cannot perform SBOM validation!
Warning: Could not fetch JSON schema to validate SBOM!\nWarning: SBOM is not valid, not writing to disk!"
```
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me that maybe periodically, every week or two, running the test suite in a network isolated environment might be useful to catch these sorts of things quicker.

@Bo98
Copy link
Member

Bo98 commented Jul 12, 2024

Realistically, how often does that file we're downloading change? Seems like something we can vendor like we do for the SPDX license list.

Any breaking changes to the schema would likely require changes on our side but because the latest schema is downloaded it would produce an error for everyone immediately.

For OCI schemas, we at least have them as versioned URLs.

@issyl0 issyl0 merged commit 868c3dc into master Jul 12, 2024
25 checks passed
@issyl0 issyl0 deleted the building-bottles-needs-network-for-sboms branch July 12, 2024 16:28
@MikeMcQuaid
Copy link
Member

Realistically, how often does that file we're downloading change? Seems like something we can vendor like we do for the SPDX license list.

Yes, we should do this.

For OCI schemas, we at least have them as versioned URLs.

I'm open to changing this however you think is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants