cli/named_args: raise priority of core casks #17681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I think this is the right approach (or at least matches how I would have expected things to work intuitively), I wonder how worried we should be about this potentially breaking existing scripts. |
|
Scripts that rely on unqualified names for third-party formulae already tread on fairly thin ice as they could easily be trumped by a Homebrew/core formula added without notice. There is no guarantee that such formula would be for the same underlying software. Main extra difference for casks is they potentially invoke sudo on |
MikeMcQuaid
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a simple implementation where formulae are higher priority than casks. In the case of a conflict between a third-party tap formula and core tap cask, change this so that the core tap cask is prioritised as this is less confusing since the
homebrew/cask/prefix is not common practice but is for third-party taps. This will likely better align with the user's intentions.