Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_assertions: Fix type of cmd param in shell_output #17688

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 12, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  ==> Testing noseyparker
  ==> /opt/homebrew/Cellar/noseyparker/0.18.1/bin/noseyparker -V
  Error: noseyparker: failed
  An exception occurred within a child process:
    TypeError: Parameter 'cmd': Expected type String, got type Pathname with value #<Pathname:/opt/homebrew/Ce...ps://github.com/Homebrew/brew>
  Caller: /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/n/noseyparker.rb:35

- This can be either a String or a Pathname, per
  the part of the `noseyparker` test that failed
  (in a different part of the test, the command is
  passed as a string).

```
  ==> Testing noseyparker
  ==> /opt/homebrew/Cellar/noseyparker/0.18.1/bin/noseyparker -V
  Error: noseyparker: failed
  An exception occurred within a child process:
    TypeError: Parameter 'cmd': Expected type String, got type Pathname with value #<Pathname:/opt/homebrew/Ce...ps://github.com/Homebrew/brew>
  Caller: /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/n/noseyparker.rb:35
```
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @issyl0!

@issyl0 issyl0 enabled auto-merge July 12, 2024 20:33
@issyl0 issyl0 merged commit 9383cfa into master Jul 12, 2024
25 checks passed
@issyl0 issyl0 deleted the boo-more-type-errors branch July 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants