Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Downloadable API in FromBottleLoader. #17695

Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jul 13, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Do we even need FromBottleLoader anymore? At least the from-URL part is useless since it doesn't work with OCI image URLs.

@Bo98
Copy link
Member

Bo98 commented Jul 13, 2024

Do we even need FromBottleLoader anymore?

brew install ./some.bottle.tar.gz is used. The URL variant shouldn't be however.

@reitermarkus
Copy link
Member Author

Let's get rid of it then. I don't think we need to even deprecate it given it was broken before.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit ab7e49c into Homebrew:master Jul 13, 2024
25 checks passed
@reitermarkus reitermarkus deleted the from-bottle-loader-downloadable branch July 13, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants