Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_spec: remove no-op Marshal use #17699

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

woodruffw
Copy link
Member

These seemingly do nothing.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Member Author

Closing; this Marshal round-trip is unfortunately load-bearing as an easy way to perform a deep clone.

@woodruffw woodruffw closed this Jul 13, 2024
@woodruffw woodruffw deleted the ww/rm-marshal-from-spec branch July 13, 2024 19:22
@Bo98
Copy link
Member

Bo98 commented Jul 13, 2024

@woodruffw
Copy link
Member Author

Would these work here? master/Library/Homebrew/extend/object/deep_dup.rb

Ah, I was looking for this exact helper. Yes, that's exactly what it needs. Reopening.

@woodruffw woodruffw restored the ww/rm-marshal-from-spec branch July 13, 2024 19:32
@woodruffw woodruffw reopened this Jul 13, 2024
@woodruffw woodruffw requested a review from Bo98 July 13, 2024 19:42
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @woodruffw!

@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review July 13, 2024 19:52
@MikeMcQuaid MikeMcQuaid merged commit 0f9ca1d into master Jul 13, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ww/rm-marshal-from-spec branch July 13, 2024 19:53
@MikeMcQuaid
Copy link
Member

(confirmed ready for review because I was sitting next to @woodruffw!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants