-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl_spec: remove no-op Marshal use #17699
Conversation
Signed-off-by: William Woodruff <[email protected]>
Closing; this |
Would these work here? https://github.com/Homebrew/brew/blob/master/Library/Homebrew/extend/object/deep_dup.rb |
Ah, I was looking for this exact helper. Yes, that's exactly what it needs. Reopening. |
This reverts commit f3847d2.
Signed-off-by: William Woodruff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @woodruffw!
(confirmed ready for review because I was sitting next to @woodruffw!) |
These seemingly do nothing.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?