Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: skip attestations on local_bottle_path #17706

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 13, 2024

This should fix observed failures on Homebrew/homebrew-core#177256 and Homebrew/homebrew-core#177260.

TL;DR: Formula#bottle is not present when a bottle is being installed from a bottle path, e.g. on CI. This is not a normal user installation path and there's no attestation to verify in these cases (since the bottle is still being produced), so we just skip it outright.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@woodruffw woodruffw self-assigned this Jul 13, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @woodruffw!

@MikeMcQuaid MikeMcQuaid merged commit f466fca into master Jul 13, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ww/fix-local-bottles branch July 13, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants