Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Resource::BottleManifest. #17709

Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jul 13, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add separate Downloadable resource type for bottle manifests.

@reitermarkus reitermarkus force-pushed the from-bottle-loader-downloadable branch from b5fef42 to 05f0795 Compare July 13, 2024 20:47
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 919530c into Homebrew:master Jul 13, 2024
25 checks passed
@reitermarkus reitermarkus deleted the from-bottle-loader-downloadable branch July 14, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants