-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attestation: improve error message when gh
is too old
#17727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandahkrishna
force-pushed
the
attestation-gh-error
branch
3 times, most recently
from
July 14, 2024 17:00
9177b46
to
c82ed9e
Compare
ZhongRuoyu
reviewed
Jul 14, 2024
nandahkrishna
force-pushed
the
attestation-gh-error
branch
2 times, most recently
from
July 14, 2024 17:24
0b6c2ac
to
fc9f69c
Compare
MikeMcQuaid
reviewed
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note then good to 🚢!
MikeMcQuaid
approved these changes
Jul 14, 2024
nandahkrishna
force-pushed
the
attestation-gh-error
branch
from
July 14, 2024 18:52
fc9f69c
to
3b206bf
Compare
woodruffw
reviewed
Jul 14, 2024
MikeMcQuaid
approved these changes
Jul 14, 2024
nandahkrishna
force-pushed
the
attestation-gh-error
branch
from
July 14, 2024 20:14
cf4d7be
to
1ae21d2
Compare
I've ignored bootstrapping the latest |
woodruffw
reviewed
Jul 14, 2024
woodruffw
reviewed
Jul 14, 2024
woodruffw
reviewed
Jul 14, 2024
woodruffw
approved these changes
Jul 14, 2024
4 tasks
mmrwoods
referenced
this pull request
Aug 1, 2024
Take 2 of #17692 but with: - provide and document `HOMEBREW_NO_VERIFY_ATTESTATIONS` - don't try to run unless there's GitHub credentials - don't try to run unless `gh` is installed - don't try to run in CI While we're here: - split out a `Homebrew::EnvConfig.devcmdrun?` helper method - add some missing `Homebrew::EnvConfig.github_api_token` presence checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Currently, when
gh
is too old to verify attestations, the error message is uninterpretable:This PR aims to improve the messaging, like below: