-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing requires for tap-info
command
#17778
Fix missing requires for tap-info
command
#17778
Conversation
Previously, running `brew tap-info --installed --json` in a github actions linux runner would throw: ``` Error: uninitialized constant Homebrew::API /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/tap.rb:1359:in `formula_names' /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/tap.rb:868:in `to_hash' /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/tap-info.rb:87:in `map' /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/tap-info.rb:87:in `print_tap_json' /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/tap-info.rb:37:in `run' /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:95:in `<main>' ``` After the setup steps: ``` steps: - name: Set up Homebrew id: set-up-homebrew uses: Homebrew/actions/setup-homebrew@master with: token: ${{ github.token }} - name: Cache Homebrew Bundler RubyGems id: cache uses: actions/cache@v3 with: path: ${{ steps.set-up-homebrew.outputs.gems-path }} key: ${{ runner.os }}-rubygems-${{ steps.set-up-homebrew.outputs.gems-hash }} restore-keys: ${{ runner.os }}-rubygems- - name: Install Homebrew Bundler RubyGems if: steps.cache.outputs.cache-hit != 'true' run: brew install-bundler-gems ```
I wonder if we want to limit the That would remove the need to add |
I'm not able to reproduce these errors on macOS on this branch either. I wonder why it'd behave differently on Linux here. |
Yeah, I'm also not able to reproduce on macOS, or weirdly even with the Here's a simple demo of the issue: kmontag/brew-pr-17778-demo#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Previously, running
brew tap-info --installed --json
in a github actions linux runner would throw:After the setup steps: