Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostic: fix XDG_DATA_DIRS check #17947

Merged
merged 1 commit into from
Aug 5, 2024
+3 −2
Merged

diagnostic: fix XDG_DATA_DIRS check #17947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/extend/os/linux/diagnostic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
end

def check_xdg_data_dirs
xdg_data_dirs = ENV.fetch("XDG_DATA_DIRS", nil)
return if xdg_data_dirs.blank? || xdg_data_dirs.split("/").include?(HOMEBREW_PREFIX/"share")
xdg_data_dirs = ENV.fetch("HOMEBREW_XDG_DATA_DIRS", nil)

Check warning on line 63 in Library/Homebrew/extend/os/linux/diagnostic.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/os/linux/diagnostic.rb#L63 

Added line #L63 was not covered by tests
return if xdg_data_dirs.blank? || xdg_data_dirs.split(":").include?(HOMEBREW_PREFIX/"share")

<<~EOS
Homebrew's share was not found in your XDG_DATA_DIRS but you have
Expand Down
1 change: 1 addition & 0 deletions bin/brew
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ USED_BY_HOMEBREW_VARS=(
SUDO_USER
TMUX
XDG_CACHE_HOME
XDG_DATA_DIRS
XDG_RUNTIME_DIR
ZDOTDIR
)
Expand Down