Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable #17988

Closed
wants to merge 5 commits into from
Closed

Stable #17988

wants to merge 5 commits into from

Commits on Jul 18, 2024

  1. docker: revert back linuxbrew's UID to 1000 

    In #17584 we have changed "linuxbrew" user's UID/GID to 1001 in order to mitigate for Ubuntu 23.04 and higher, which started creating a default "ubuntu" user taking over UID/GID 1000 .

While we may desire a deterministic UID in the homebrew docker image, the change effectively modified the behaviour for all current 3 images based on Ubuntu 18.04 20.04 and 22.04 by changing the linuxbrew's user UID/GID from 1000 to 1001. As per https://hub.docker.com/u/homebrew, we do not currently publish an image for 24.04 which the change is mitigating for.

Rather than mitigating for indeterministic behaviour of upstream changes, this commit implements the workaround in https://bugs.launchpad.net/cloud-images/+bug/2005129 to delete the default "ubuntu" user.
    @andreineculau @Bo98
    andreineculau authored and Bo98 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    658b9a2 View commit details
    Browse the repository at this point in the history

  2. cli/named_args: raise priority of core casks

    @Bo98
    Bo98 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    453b2e0 View commit details
    Browse the repository at this point in the history

  3. utils/analytics: strip out more data. 

    We've filter this out in `brew formula-analytics` too but let's avoid
sending it here in the first place so we can delete the
formula-analytics filtering later.
    @MikeMcQuaid @Bo98
    MikeMcQuaid authored and Bo98 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dc72111 View commit details
    Browse the repository at this point in the history

  4. utils/analytics: fix handling of newlines

    @Bo98
    Bo98 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    772149d View commit details
    Browse the repository at this point in the history

  5. dependency: fix missed upgrades when an alias is changed to a formula

    @Bo98
    Bo98 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c3ae032 View commit details
    Browse the repository at this point in the history