Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude sorbet assignments from Style/MutableConstant cop #18367

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Sep 20, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Re-opening #18091 for consideration, as my upstream PR has been ignored for a month…

This is mostly the same content, although there are some light changes for sorbet-compatibility here.

@MikeMcQuaid MikeMcQuaid merged commit 06f60ff into master Sep 23, 2024
28 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @dduugg!

@MikeMcQuaid MikeMcQuaid deleted the skip-sorbet-assignments branch September 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants