Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: drop ubuntu 18.04 devcontainer #18384

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Sep 23, 2024

Ubuntu 18.04 is EOL now, so stop building containers for it.

Also adjust some dates in the documentation

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@iMichka
Copy link
Member Author

iMichka commented Sep 23, 2024

Is someone still using .devcontainer/ubuntu18.04/devcontainer.json ?

@Bo98
Copy link
Member

Bo98 commented Sep 24, 2024

We should add a .docker-deprecate message to the image (and the org.opencontainers.image.support.end-of-support label) beforehand to announce this removal for the next minor release or something. a098519

For 16.04 we announced the deprecation in 3.6.0 (or well technically 3.6.1 as we just missed it and called it close enough) and removed it in 4.0.something (a little late because 4.0.0 was hectic).

@MikeMcQuaid
Copy link
Member

Is someone still using .devcontainer/ubuntu18.04/devcontainer.json ?

No, please feel free to remove.

Ubuntu 18.04 is EOL now, so stop building devcontainers for it.

Also adjust some dates in the documentation.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMichka! Have removed Docker image deprecation, pulled that into #18387.

@MikeMcQuaid MikeMcQuaid merged commit 341a1ef into Homebrew:master Sep 24, 2024
27 checks passed
@iMichka iMichka deleted the ubuntu18 branch September 25, 2024 19:19
@iMichka iMichka changed the title linux: drop ubuntu 18.04 linux: drop ubuntu 18.04 devcontainer Sep 25, 2024
@iMichka
Copy link
Member Author

iMichka commented Sep 25, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants