Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows/tests: use the container and macos-14 for some jobs #18395

Merged
merged 3 commits into from
Sep 30, 2024
Merged

workflows/tests: use the container and macos-14 for some jobs #18395

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89b8e32
workflows/tests: use the container for some jobs
ZhongRuoyu Sep 24, 2024
c4f80ed
workflows/tests: run tap syntax job on `macos-14`
ZhongRuoyu Sep 24, 2024
64ddb6e
workflows/tests: only run RSpec tests with core tap on macOS
ZhongRuoyu Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
name: tap syntax
needs: syntax
if: github.repository_owner == 'Homebrew'
runs-on: ubuntu-22.04
runs-on: macos-14
steps:
- name: Set up Homebrew
id: set-up-homebrew
Expand Down Expand Up @@ -142,7 +142,9 @@ jobs:
name: formula audit
needs: syntax
if: github.repository_owner == 'Homebrew'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
container:
image: ghcr.io/homebrew/brew:master
steps:
- name: Set up Homebrew
id: set-up-homebrew
Expand Down Expand Up @@ -251,10 +253,10 @@ jobs:
include:
- name: tests (online)
test-flags: --online --coverage
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
- name: tests (generic OS)
test-flags: --generic --coverage
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
- name: tests (Ubuntu 22.04)
test-flags: --coverage
runs-on: ubuntu-22.04
Expand All @@ -272,7 +274,10 @@ jobs:
id: set-up-homebrew
uses: Homebrew/actions/setup-homebrew@master
with:
core: true
# We only test needs_homebrew_core tests on macOS because
# homebrew/core is not available by default on GitHub-hosted Ubuntu
# runners, and it's expensive to tap it.
core: ${{ runner.os == 'macOS' }}
cask: false
test-bot: false

Expand Down Expand Up @@ -360,13 +365,16 @@ jobs:
needs: syntax
if: github.repository_owner == 'Homebrew'
runs-on: ${{ matrix.runs-on }}
container: ${{ matrix.container }}
strategy:
matrix:
include:
- name: test default formula (Ubuntu 22.04)
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
container: ghcr.io/homebrew/ubuntu22.04:master
- name: test default formula (Ubuntu 20.04)
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
container: ghcr.io/homebrew/ubuntu20.04
- name: test default formula (macOS 13 x86_64)
runs-on: macos-13
- name: test default formula (macOS 14 arm64)
Expand Down
Loading