Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/--cache: avoid exception on missing HEAD #18422

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 26, 2024

Also add cask to description

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Original T.must is not guaranteed and will lead to less readable exceptions, e.g.

brew --cache --HEAD [email protected]
Error: Passed `nil` into T.must
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11581/lib/types/_types.rb:222:in `must'
/opt/homebrew/Library/Homebrew/cmd/--cache.rb:116:in `print_formula_cache'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11581/lib/types/private/methods/call_validation.rb:270:in `bind_call'

Instead, this change just outputs a warning similar to missing bottle scenario. Message used is same as what is output when running brew install --HEAD on missing HEAD.

brew --cache --HEAD [email protected]
Warning: No head is defined for [email protected].

Also add cask to description
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit 05cde76 into master Sep 26, 2024
30 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cmd-cache-touchup branch September 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants