Build brew docker image for x86 and arm64 #18489
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?When opening the
brew
repository with VSCode on am M1 Mac, it prompted me to reopen the window in a devcontainer. I agreed, then that devcontainer failed to startup, saying there was no such image. Attempting to pull manually resulted in this:This PR will build the
linux/arm64
image in parallel with the amd64 image, allowing arm-based macs (and any other arm64-based system) to use the brew container.