dev-cmd/bump-formula-pr: always use full git repo as tap remote #18538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Hi there folks!
I'm currently taking care of my GitHub Action action-homebrew-bump-formula and wanted to move my test formulae from separate repository to the same repository where the action is stored.
I've run into an issue, because the repository is not named properly (i.e.
$USER/homebrew-$TAP
),brew bump-formula-pr
would try to access non-existent repository named for exampledawidd6/tap
, it depends how I cloned the tap of course. I've tracked it down to this changed line. Didn't test it on homebrew-core, but I think it should work the same as for my repository.Steps to reproduce:
brew tap dawidd6/tap https://github.com/dawidd6/action-homebrew-bump-formula.git
brew bump-formula-pr --no-audit --no-browse --no-fork --version=0.1.12 --force dawidd6/tap/test-formula-url