-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add determine-cask-runners command #18594
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
34896e7
to
15d4c7e
Compare
15d4c7e
to
cac9b0e
Compare
eb4536d
to
94318f4
Compare
Testing this locally using the CodeQL CLI, the errors relate to the repeating However, I tested the regex changes locally and it works for something like Making the repeating parts non-greedy ( I've created a PR in homebrew/cask first as a smoke test (Homebrew/homebrew-cask#189969) and, if nothing explodes, I'll push the changes here as well. |
ef951d1
to
9784015
Compare
The tests aren't exhaustive, I'm not exactly how much coverage we are looking for here, as any major concerns will be revealed in CI which we can't quite replicate in the test suite. |
5a7a9e0
to
faf7830
Compare
faf7830
to
929b7ce
Compare
929b7ce
to
ac1255c
Compare
end | ||
|
||
sig { params(cask_content: String).returns(T::Hash[T::Hash[Symbol, Symbol], Float]) } | ||
def filter_runners(cask_content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need to be in this PR, but this should probably have some unit tests.
e00ebd9
to
ff05d39
Compare
ff05d39
to
280b1ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bevanjkay!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is a draft of moving the commands that generate the matrixes for our
homebrew-cask
CI to a DevCmd in Brew.