edge case handleing #18621
Closed
edge case handleing #18621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* **Library/Homebrew/build.rb** - Add rescue block to handle errors during the installation of formula * **Library/Homebrew/cmd/deps.rb** - Add rescue blocks to handle errors during dependency processing and dependents processing * **Library/Homebrew/debrew.rb** - Add logging and retry options to the debugging tool - Add method to log exception details to a file * **Library/Homebrew/formula_assertions.rb** - Add assert_raises and assert_nothing_raised methods for more exhaustive assertions * **Library/Homebrew/formula_auditor.rb** - Add rescue block to handle errors during formula audits
* **dependency_collector.rb** - Add edge case handling for unsupported dependency specifications and URL extensions in `parse_spec` method - Improve error messages in `fetch` method * **dependency.rb** - Add edge case handling for circular dependencies in `expand` method - Improve error messages in `installed?` method * **formula_installer.rb** - Add edge case handling for failed installations in `install` method - Improve error messages in `check_install_sanity` method * **cask_dependent.rb** - Add edge case handling for missing dependencies in `initialize` method - Improve error messages in `runtime_dependencies` method * **exceptions.rb** - Improve error messages for dependency-related exceptions * **formula_auditor.rb** - Add edge case handling for missing dependencies in `audit_deps` method * **api.rb** - Add edge case handling for missing API responses in `fetch` method - Improve error messages in `fetch` method
|
Thanks for the PR! What kind of edge cases are you trying to catch here? How do I reproduce them? |
|
Closing until there's more explanation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?