Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/python: link manpages by default #18715

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 5, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Seems okay to make default. Been a couple years since I added this and haven't seen any issues with ones we've manually enabled. May as well expose the man pages if they are already installed and manually disable any that cause issues.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@MikeMcQuaid MikeMcQuaid merged commit e1c8b33 into master Nov 5, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the python-link-man-default branch November 5, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants