-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): bump json from 2.7.6 to 2.8.1 in /Library/Homebrew #18725
build(deps-dev): bump json from 2.7.6 to 2.8.1 in /Library/Homebrew #18725
Conversation
Bumps [json](https://github.com/ruby/json) from 2.7.6 to 2.8.1. - [Release notes](https://github.com/ruby/json/releases) - [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md) - [Commits](ruby/json@v2.7.6...v2.8.1) --- updated-dependencies: - dependency-name: json dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
5470905
to
ddece8a
Compare
5ed1ff4
to
e11a768
Compare
e11a768
to
acb4edd
Compare
b3f7c9f
to
ebe1e50
Compare
puts JSON.pretty_generate(json) | ||
# json v2.8.1 is inconsistent it how it renders empty arrays, | ||
# so we use `[]` for consistency: | ||
puts JSON.pretty_generate(json).gsub(/\[\n\n\s*\]/, "[]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a bug that should be reported upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on it. It's actually a bug that's been around a while, you can even see it in our fixtures:
"old_tokens": [ | |
], |
There's also an SO question around the issue: https://stackoverflow.com/questions/58361230/avoiding-extra-lines-in-ruby-json-pretty-generate
The unusual thing (to me) is seeing different output on substantially similar inupts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't repro on my mac, so I've given up filing an issue. (It seems limited to the "generic" os in testing, in case you want to chase it down.)
Thanks @dduugg! |
Bumps json from 2.7.6 to 2.8.1.
Release notes
Sourced from json's releases.
... (truncated)
Changelog
Sourced from json's changelog.
Commits
49650f7
Release 2.8.107cf261
Fix gemspec to include .jar filesb9c8024
Merge pull request #693 from casperisfine/update-changelog8071cc6
Release 2.8.0f5812d8
Update benchmark annotations3f950f2
Merge pull request #692 from casperisfine/custom-parse-int3a4dc9e
Implement a fast path for integer parsingd315ac8
Merge pull request #689 from casperisfine/parser-escape94d679f
Merge pull request #690 from nobu/right-shift-ucharfb82373
Fix right shift warningsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)